Player gun, bullet and its collisiions. Refactor.

metroidvania/Scenes/Player/Player.gd

@@ -0,0 +1,123 @@
+extends KinematicBody2D
+
+const DustEffect = preload("res://Scenes/Effects/DustEffect.tscn")
+const PlayerBullet = preload("res://Scenes/Player/PlayerBullet.tscn")
+
+export (int) var acceleration = 512
+export (int) var max_speed = 64
+export (float) var friction = 0.25
+export (int) var gravity = 200
+export (int) var jump_force = 128
+export (int) var max_slope = 46
+export (int) var bullet_speed = 250
+
+var motion = Vector2.ZERO
+var snap_vector = Vector2.ZERO
+var just_jumped= false
+
+onready var sprite = $Sprite
+onready var animation = $Animation
+onready var coyoteJumpTimer = $CoyoteJumpTimer
+onready var playerGun = $Sprite/PlayerGun
+onready var muzzle = $Sprite/PlayerGun/Sprite/Muzzle
+onready var fireBulletTimer = $FireBulletTimer
+
+
+func _physics_process(delta):
+	just_jumped = false
+	var input_vector = get_input_vector()
+	apply_horizontal_force(input_vector, delta)
+	apply_friction(input_vector)
+	update_snap_vector()
+	jump_check()
+	apply_gravity(delta)
+	update_animations(input_vector)
+	move()
+
+	if Input.is_action_pressed("fire") and fireBulletTimer.time_left == 0:
+		fire_bullet()
+
+func fire_bullet():
+	var bullet = Utils.instance_scene_on_main(PlayerBullet, muzzle.global_position)
+	bullet.velocity = Vector2.RIGHT.rotated(playerGun.rotation) * bullet_speed
+	bullet.velocity.x *= sprite.scale.x # Flip left/right depending on players direction
+	bullet.rotation = bullet.velocity.angle()
+	fireBulletTimer.start()
+
+func create_dust_effect():
+	var dust_position = global_position
+	dust_position.x += rand_range(-4, 4)
+	Utils.instance_scene_on_main(DustEffect, dust_position)
+
+func get_input_vector():
+	var input_vector = Vector2.ZERO
+	input_vector.x = Input.get_action_strength("ui_right") - Input.get_action_strength("ui_left")
+	return input_vector
+	
+func apply_horizontal_force(input_vector, delta):
+	if input_vector.x != 0:
+		motion.x += input_vector.x * acceleration * delta
+		motion.x = clamp(motion.x, -max_speed, max_speed)  # Set the max motion
+
+func apply_friction(input_vector):
+	if input_vector.x == 0 and is_on_floor():
+		motion.x = lerp(motion.x, 0, friction)
+
+func update_snap_vector():
+	if is_on_floor():
+		snap_vector = Vector2.DOWN
+
+func jump_check():
+	if is_on_floor() or coyoteJumpTimer.time_left > 0:
+		if Input.is_action_just_pressed("ui_select"):
+			motion.y = -jump_force
+			snap_vector = Vector2.ZERO
+			just_jumped = true
+	else:
+		if Input.is_action_just_released("ui_select") and motion.y < -jump_force/2:
+			motion.y = motion.y/2
+			
+func apply_gravity(delta):
+	if not is_on_floor():
+		motion.y += gravity * delta
+		motion.y = min(motion.y, jump_force)
+
+func update_animations(input_vector):
+	sprite.scale.x = sign(get_local_mouse_position().x)
+	animation.playback_speed = 1
+	
+	if input_vector.x != 0:
+		animation.playback_speed = sign(input_vector.x * sprite.scale.x)
+		animation.play("Run")
+	else:
+		animation.play("Idle")
+
+	if not is_on_floor():
+		animation.play("Jump")
+
+func move():
+	var was_on_air = not is_on_floor()
+	var was_on_floor = is_on_floor()
+	var last_position = position
+	var last_motion = motion
+	
+	motion = move_and_slide_with_snap(motion, snap_vector * 4, Vector2.UP, true, 4, deg2rad(max_slope), false)
+
+	# Just landed
+	if was_on_air and is_on_floor():
+		# Keep previous momentum when landing on slopes
+		motion.x = last_motion.x
+		create_dust_effect()
+
+	# Just left ground
+	if was_on_floor and not is_on_floor() and not just_jumped:
+		# Fixes "gap" when jumping off a cliff [TODO]
+		motion.y = 0
+		position.y = last_position.y
+		coyoteJumpTimer.start()
+		
+	# Prevent Sliding (hack) [NOT WORKING]
+	# If we are on floor, the floor isn't moving and our motion is really tiny
+	if is_on_floor() and get_floor_velocity().length() == 0 and abs(motion.x) < 1:
+		position.x = last_position.x
+

metroidvania/Scenes/Player/Player.tscn

@@ -0,0 +1,117 @@
+[gd_scene load_steps=9 format=2]
+
+[ext_resource path="res://Assets/Player/Player.png" type="Texture" id=1]
+[ext_resource path="res://Scenes/Player/Player.gd" type="Script" id=2]
+[ext_resource path="res://DebugKinematicBody2D.tscn" type="PackedScene" id=3]
+[ext_resource path="res://Scenes/Player/PlayerGun.tscn" type="PackedScene" id=4]
+
+
+
+[sub_resource type="RectangleShape2D" id=1]
+extents = Vector2( 4, 7 )
+
+[sub_resource type="Animation" id=2]
+resource_name = "Idle"
+length = 1.2
+loop = true
+tracks/0/type = "value"
+tracks/0/path = NodePath("Sprite:frame")
+tracks/0/interp = 1
+tracks/0/loop_wrap = true
+tracks/0/imported = false
+tracks/0/enabled = true
+tracks/0/keys = {
+"times": PoolRealArray( 0, 0.3, 0.6, 0.9 ),
+"transitions": PoolRealArray( 1, 1, 1, 1 ),
+"update": 1,
+"values": [ 0, 1, 2, 3 ]
+}
+
+[sub_resource type="Animation" id=3]
+resource_name = "Jump"
+length = 0.1
+tracks/0/type = "value"
+tracks/0/path = NodePath("Sprite:frame")
+tracks/0/interp = 1
+tracks/0/loop_wrap = true
+tracks/0/imported = false
+tracks/0/enabled = true
+tracks/0/keys = {
+"times": PoolRealArray( 0 ),
+"transitions": PoolRealArray( 1 ),
+"update": 1,
+"values": [ 11 ]
+}
+
+[sub_resource type="Animation" id=4]
+resource_name = "Run"
+length = 0.6
+loop = true
+tracks/0/type = "value"
+tracks/0/path = NodePath("Sprite:frame")
+tracks/0/interp = 1
+tracks/0/loop_wrap = true
+tracks/0/imported = false
+tracks/0/enabled = true
+tracks/0/keys = {
+"times": PoolRealArray( 0, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6 ),
+"transitions": PoolRealArray( 1, 1, 1, 1, 1, 1, 1 ),
+"update": 1,
+"values": [ 4, 5, 6, 7, 8, 9, 7 ]
+}
+tracks/1/type = "method"
+tracks/1/path = NodePath(".")
+tracks/1/interp = 1
+tracks/1/loop_wrap = true
+tracks/1/imported = false
+tracks/1/enabled = true
+tracks/1/keys = {
+"times": PoolRealArray( 0.3, 0.6 ),
+"transitions": PoolRealArray( 1, 1 ),
+"values": [ {
+"args": [  ],
+"method": "create_dust_effect"
+}, {
+"args": [  ],
+"method": "create_dust_effect"
+} ]
+}
+
+[node name="Player" type="KinematicBody2D"]
+collision_mask = 2
+script = ExtResource( 2 )
+
+[node name="Sprite" type="Sprite" parent="."]
+position = Vector2( 0, -12 )
+texture = ExtResource( 1 )
+hframes = 12
+frame = 4
+
+[node name="PlayerGun" parent="Sprite" instance=ExtResource( 4 )]
+show_behind_parent = true
+position = Vector2( 1, 3 )
+
+[node name="Collision" type="CollisionShape2D" parent="."]
+position = Vector2( 0, -7 )
+shape = SubResource( 1 )
+
+[node name="Animation" type="AnimationPlayer" parent="."]
+anims/Idle = SubResource( 2 )
+anims/Jump = SubResource( 3 )
+anims/Run = SubResource( 4 )
+
+[node name="Debug" parent="." instance=ExtResource( 3 )]
+visible = false
+
+[node name="CameraFollow" type="RemoteTransform2D" parent="."]
+position = Vector2( 0, -8 )
+update_rotation = false
+update_scale = false
+
+[node name="CoyoteJumpTimer" type="Timer" parent="."]
+wait_time = 0.2
+one_shot = true
+
+[node name="FireBulletTimer" type="Timer" parent="."]
+wait_time = 0.3
+one_shot = true

metroidvania/Scenes/Player/PlayerBullet.gd

@@ -0,0 +1,5 @@
+extends "res://Scenes/Objects/Proyectile.gd"
+
+func _ready():
+	# Do not run _process()
+	set_process(false)

metroidvania/Scenes/Player/PlayerBullet.tscn

@@ -0,0 +1,59 @@
+[gd_scene load_steps=6 format=2]
+
+[ext_resource path="res://Scenes/Player/PlayerBullet.gd" type="Script" id=1]
+[ext_resource path="res://Assets/Player/PlayerBullet.png" type="Texture" id=2]
+[ext_resource path="res://Scenes/Objects/Proyectile.tscn" type="PackedScene" id=3]
+
+[sub_resource type="Animation" id=1]
+resource_name = "Fire"
+length = 0.1
+step = 0.05
+tracks/0/type = "value"
+tracks/0/path = NodePath("Sprite:frame")
+tracks/0/interp = 1
+tracks/0/loop_wrap = true
+tracks/0/imported = false
+tracks/0/enabled = true
+tracks/0/keys = {
+"times": PoolRealArray( 0, 0.05 ),
+"transitions": PoolRealArray( 1, 1 ),
+"update": 1,
+"values": [ 0, 1 ]
+}
+tracks/1/type = "method"
+tracks/1/path = NodePath(".")
+tracks/1/interp = 1
+tracks/1/loop_wrap = true
+tracks/1/imported = false
+tracks/1/enabled = true
+tracks/1/keys = {
+"times": PoolRealArray( 0.05 ),
+"transitions": PoolRealArray( 1 ),
+"values": [ {
+"args": [ true ],
+"method": "set_process"
+} ]
+}
+
+[sub_resource type="RectangleShape2D" id=2]
+extents = Vector2( 4, 2 )
+
+[node name="PlayerBullet" instance=ExtResource( 3 )]
+script = ExtResource( 1 )
+
+[node name="Sprite" parent="." index="0"]
+texture = ExtResource( 2 )
+hframes = 2
+frame = 1
+
+[node name="AnimationPlayer" parent="." index="2"]
+autoplay = "Fire"
+anims/Fire = SubResource( 1 )
+
+[node name="Hitbox" parent="." index="3"]
+collision_mask = 10
+
+[node name="Collider" parent="Hitbox" index="0"]
+shape = SubResource( 2 )
+
+[editable path="Hitbox"]

metroidvania/Scenes/Player/PlayerGun.gd

@@ -0,0 +1,6 @@
+extends Node2D
+
+
+func _process(_delta):
+	var player = get_parent()
+	rotation = player.get_local_mouse_position().angle()

metroidvania/Scenes/Player/PlayerGun.tscn

@@ -0,0 +1,15 @@
+[gd_scene load_steps=3 format=2]
+
+[ext_resource path="res://Scenes/Player/PlayerGun.gd" type="Script" id=1]
+[ext_resource path="res://Assets/Player/PlayerGun.png" type="Texture" id=2]
+
+[node name="PlayerGun" type="Node2D"]
+script = ExtResource( 1 )
+
+[node name="Sprite" type="Sprite" parent="."]
+position = Vector2( -2, -2 )
+texture = ExtResource( 2 )
+centered = false
+
+[node name="Muzzle" type="Position2D" parent="Sprite"]
+position = Vector2( 13, 2 )