tweak plugin id/version injection

* define BUNDLE_NAME after including build/setup.mk (just for clarity, not correctness)
* separate plugin id from version with dash in bundle name to match Mattermost package
* fix various js/go idioms (some pre-existing!)
* fix error message
This commit is contained in:
Jesse Hallam 2018-09-20 11:36:53 -04:00
parent a0e9acdbaf
commit 5b2980d1ac
No known key found for this signature in database
GPG key ID: E7959EB6518AF966
6 changed files with 28 additions and 17 deletions

View file

@ -1,4 +1,4 @@
import Manifest from './manifest';
import {id as pluginId} from './manifest';
export default class Plugin {
// eslint-disable-next-line no-unused-vars
@ -7,4 +7,4 @@ export default class Plugin {
}
}
window.registerPlugin(Manifest.PluginId, new Plugin());
window.registerPlugin(pluginId, new Plugin());

View file

@ -1,4 +1,4 @@
export default {
PluginId: 'com.mattermost.sample-plugin',
PluginVersion: '0.0.1',
id: 'com.mattermost.sample-plugin',
version: '0.0.1',
};