fmartingr/mattermost-plugin-attachments-remover
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clarify avoiding API while holding configurationLock

Browse source
This commit is contained in:
Jesse Hallam 2018-10-01 17:18:36 -04:00
parent 8adb629abd
commit eb2678c625
No known key found for this signature in database
GPG key ID: E7959EB6518AF966
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
server/configuration.go
View file

@ -43,7 +43,8 @@ func (p *Plugin) getConfiguration() *configuration {
// setConfiguration replaces the active configuration under lock.
//
// Do not call setConfiguration while holding the configurationLock, as sync.Mutex is not
// reentrant.
// reentrant. In particular, avoid using the plugin API entirely, as this may in turn trigger a
// hook back into the plugin. If that hook attempts to acquire this lock, a deadlock may occur.
func (p *Plugin) setConfiguration(configuration *configuration) {
p.configurationLock.Lock()
defer p.configurationLock.Unlock()