mattermost-plugin-bridge-xmpp/server/model/bridge.go
Felipe Martin 69a67704f4
fix: prevent dangling XMPP connections during configuration updates
- Add getConfiguration() methods to both bridges for thread-safe config access
- Refactor UpdateConfiguration() methods to prevent mutex deadlock by releasing lock before blocking operations
- Fix XMPP bridge to properly disconnect existing bridgeClient before creating new one
- Add comprehensive timeout support to XMPP client (30s connection, 10s operations, 5s ping)
- Implement proper disconnection with offline presence
- Update all interfaces to use *config.Configuration for type safety

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-04 19:04:43 +02:00

207 lines
6.2 KiB
Go

package model
import (
"context"
"fmt"
"github.com/mattermost/mattermost-plugin-bridge-xmpp/server/config"
)
type BridgeID string
type UserState int
const (
UserStateOnline UserState = iota
UserStateAway
UserStateBusy
UserStateOffline
)
// CreateChannelMappingRequest contains information needed to create a channel mapping
type CreateChannelMappingRequest struct {
ChannelID string // Mattermost channel ID
BridgeName string // Name of the bridge (e.g., "xmpp")
BridgeRoomID string // Remote room/channel ID (e.g., JID for XMPP)
UserID string // ID of user who triggered the mapping creation
TeamID string // Team ID where the channel belongs
}
// Validate checks if all required fields are present and valid
func (r CreateChannelMappingRequest) Validate() error {
if r.ChannelID == "" {
return fmt.Errorf("channelID cannot be empty")
}
if r.BridgeName == "" {
return fmt.Errorf("bridgeName cannot be empty")
}
if r.BridgeRoomID == "" {
return fmt.Errorf("bridgeRoomID cannot be empty")
}
if r.UserID == "" {
return fmt.Errorf("userID cannot be empty")
}
if r.TeamID == "" {
return fmt.Errorf("teamID cannot be empty")
}
return nil
}
// DeleteChannelMappingRequest contains information needed to delete a channel mapping
type DeleteChannelMappingRequest struct {
ChannelID string // Mattermost channel ID
BridgeName string // Name of the bridge (e.g., "xmpp")
UserID string // ID of user who triggered the mapping deletion
TeamID string // Team ID where the channel belongs
}
// Validate checks if all required fields are present and valid
func (r DeleteChannelMappingRequest) Validate() error {
if r.ChannelID == "" {
return fmt.Errorf("channelID cannot be empty")
}
if r.BridgeName == "" {
return fmt.Errorf("bridgeName cannot be empty")
}
if r.UserID == "" {
return fmt.Errorf("userID cannot be empty")
}
if r.TeamID == "" {
return fmt.Errorf("teamID cannot be empty")
}
return nil
}
type BridgeManager interface {
// RegisterBridge registers a bridge with the given name. Returns an error if the name is empty,
// the bridge is nil, or a bridge with the same name is already registered.
RegisterBridge(name string, bridge Bridge) error
// StartBridge starts the bridge with the given name. Returns an error if the bridge
// is not registered or fails to start.
StartBridge(name string) error
// StopBridge stops the bridge with the given name. Returns an error if the bridge
// is not registered or fails to stop.
StopBridge(name string) error
// UnregisterBridge removes the bridge with the given name from the manager.
// The bridge is stopped before removal if it's currently connected.
// Returns an error if the bridge is not registered.
UnregisterBridge(name string) error
// GetBridge retrieves the bridge instance with the given name.
// Returns an error if the bridge is not registered.
GetBridge(name string) (Bridge, error)
// ListBridges returns a list of all registered bridge names.
ListBridges() []string
// HasBridge checks if a bridge with the given name is registered.
HasBridge(name string) bool
// HasBridges checks if any bridges are currently registered.
HasBridges() bool
// Shutdown stops and unregisters all bridges. Returns an error if any bridge
// fails to stop, but continues to attempt stopping all bridges.
Shutdown() error
// OnPluginConfigurationChange propagates configuration changes to all registered bridges.
// Returns an error if any bridge fails to update its configuration, but continues to
// attempt updating all bridges.
OnPluginConfigurationChange(config *config.Configuration) error
// CreateChannelMapping is called when a channel mapping is created.
CreateChannelMapping(req CreateChannelMappingRequest) error
// DeleteChannepMapping is called when a channel mapping is deleted.
DeleteChannepMapping(req DeleteChannelMappingRequest) error
}
type Bridge interface {
// UpdateConfiguration updates the bridge configuration
UpdateConfiguration(config *config.Configuration) error
// Start starts the bridge
Start() error
// Stop stops the bridge
Stop() error
// CreateChannelMapping creates a mapping between a Mattermost channel ID and an bridge room ID.
CreateChannelMapping(channelID, roomJID string) error
// GetChannelMapping retrieves the bridge room ID for a given Mattermost channel ID.
GetChannelMapping(channelID string) (string, error)
// DeleteChannelMapping removes a mapping between a Mattermost channel ID and a bridge room ID.
DeleteChannelMapping(channelID string) error
// RoomExists checks if a room/channel exists on the remote service.
RoomExists(roomID string) (bool, error)
// GetRoomMapping retrieves the Mattermost channel ID for a given room ID (reverse lookup).
GetRoomMapping(roomID string) (string, error)
// IsConnected checks if the bridge is connected to the remote service.
IsConnected() bool
// Ping actively tests the bridge connection health by sending a lightweight request.
Ping() error
// GetUserManager returns the user manager for this bridge.
GetUserManager() BridgeUserManager
}
// BridgeUser represents a user connected to any bridge service
type BridgeUser interface {
// Validation
Validate() error
// Identity (bridge-agnostic)
GetID() string
GetDisplayName() string
// State management
GetState() UserState
SetState(state UserState) error
// Channel operations (abstracted from rooms/channels/groups)
JoinChannel(channelID string) error
LeaveChannel(channelID string) error
SendMessageToChannel(channelID, message string) error
// Connection lifecycle
Connect() error
Disconnect() error
IsConnected() bool
Ping() error
// Channel existence check
CheckChannelExists(channelID string) (bool, error)
// Goroutine lifecycle
Start(ctx context.Context) error
Stop() error
}
// BridgeUserManager manages users for a specific bridge
type BridgeUserManager interface {
// User lifecycle
CreateUser(user BridgeUser) error
GetUser(userID string) (BridgeUser, error)
DeleteUser(userID string) error
ListUsers() []BridgeUser
HasUser(userID string) bool
// Manager lifecycle
Start(ctx context.Context) error
Stop() error
// Configuration updates
UpdateConfiguration(config *config.Configuration) error
// Bridge type identification
GetBridgeType() string
}