Upgrade updateassets command to use templates with manifest context

- Convert all asset files to be processed as Go templates
- Expose plugin manifest data via .Manifest key in template context
- Add template processing infrastructure with TemplateContext struct
- Update asset processing pipeline to execute templates instead of direct file copying
- Fix info command output format to use plain text instead of structured logging
- All tests passing with proper error handling and backward compatibility

This enables dynamic asset files that can access plugin manifest properties
like {{.Manifest.Id}}, {{.Manifest.Version}}, and conditional logic based
on plugin configuration.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Felipe M 2025-07-14 21:33:58 +02:00
parent 03c521f237
commit 04fa4154b3
No known key found for this signature in database
GPG key ID: 52E5D65FCF99808A
2 changed files with 77 additions and 31 deletions

View file

@ -8,6 +8,9 @@ import (
"os"
"path/filepath"
"strings"
"text/template"
"github.com/mattermost/mattermost/server/public/model"
)
//go:embed assets/*
@ -45,6 +48,7 @@ func RunUpdateAssetsCommand(args []string, pluginPath string) error {
hasWebapp: hasWebapp,
updatedCount: &updatedCount,
pluginCtlConfig: pluginCtlConfig,
manifest: manifest,
}
err = fs.WalkDir(assetsFS, "assets", func(path string, d fs.DirEntry, err error) error {
@ -121,6 +125,12 @@ type AssetProcessorConfig struct {
hasWebapp bool
updatedCount *int
pluginCtlConfig *PluginCtlConfig
manifest *model.Manifest
}
// TemplateContext holds the data available to templates.
type TemplateContext struct {
Manifest *model.Manifest
}
func processAssetEntry(path string, d fs.DirEntry, err error, config AssetProcessorConfig) error {
@ -151,21 +161,21 @@ func processAssetEntry(path string, d fs.DirEntry, err error, config AssetProces
return createDirectory(targetPath)
}
return processAssetFile(path, targetPath, relativePath, config.updatedCount)
return processAssetFile(path, targetPath, relativePath, config)
}
func processAssetFile(embeddedPath, targetPath, relativePath string, updatedCount *int) error {
shouldUpdate, err := shouldUpdateFile(embeddedPath, targetPath)
func processAssetFile(embeddedPath, targetPath, relativePath string, config AssetProcessorConfig) error {
shouldUpdate, err := shouldUpdateFile(embeddedPath, targetPath, config.manifest)
if err != nil {
return err
}
if shouldUpdate {
err = updateFile(embeddedPath, targetPath, relativePath)
err = updateFile(embeddedPath, targetPath, relativePath, config.manifest)
if err != nil {
return err
}
(*updatedCount)++
(*config.updatedCount)++
}
return nil
@ -179,10 +189,11 @@ func createDirectory(targetPath string) error {
return nil
}
func shouldUpdateFile(embeddedPath, targetPath string) (bool, error) {
content, err := assetsFS.ReadFile(embeddedPath)
func shouldUpdateFile(embeddedPath, targetPath string, manifest *model.Manifest) (bool, error) {
// Process the template to get the final content
processedContent, err := processTemplate(embeddedPath, manifest)
if err != nil {
return false, fmt.Errorf("failed to read embedded file %s: %w", embeddedPath, err)
return false, fmt.Errorf("failed to process template %s: %w", embeddedPath, err)
}
existingContent, err := os.ReadFile(targetPath)
@ -191,13 +202,14 @@ func shouldUpdateFile(embeddedPath, targetPath string) (bool, error) {
return true, nil //nolint:nilerr
}
return !bytes.Equal(existingContent, content), nil
return !bytes.Equal(existingContent, processedContent), nil
}
func updateFile(embeddedPath, targetPath, relativePath string) error {
content, err := assetsFS.ReadFile(embeddedPath)
func updateFile(embeddedPath, targetPath, relativePath string, manifest *model.Manifest) error {
// Process the template to get the final content
processedContent, err := processTemplate(embeddedPath, manifest)
if err != nil {
return fmt.Errorf("failed to read embedded file %s: %w", embeddedPath, err)
return fmt.Errorf("failed to process template %s: %w", embeddedPath, err)
}
parentDir := filepath.Dir(targetPath)
@ -205,7 +217,7 @@ func updateFile(embeddedPath, targetPath, relativePath string) error {
return fmt.Errorf("failed to create parent directory %s: %w", parentDir, err)
}
if err := os.WriteFile(targetPath, content, filePermissions); err != nil {
if err := os.WriteFile(targetPath, processedContent, filePermissions); err != nil {
return fmt.Errorf("failed to write file %s: %w", targetPath, err)
}
@ -213,3 +225,32 @@ func updateFile(embeddedPath, targetPath, relativePath string) error {
return nil
}
// processTemplate processes a template file with the manifest context.
func processTemplate(embeddedPath string, manifest *model.Manifest) ([]byte, error) {
// Read the template content
templateContent, err := assetsFS.ReadFile(embeddedPath)
if err != nil {
return nil, fmt.Errorf("failed to read embedded file %s: %w", embeddedPath, err)
}
// Create template context
context := TemplateContext{
Manifest: manifest,
}
// Create and parse the template
tmpl, err := template.New(embeddedPath).Parse(string(templateContent))
if err != nil {
return nil, fmt.Errorf("failed to parse template %s: %w", embeddedPath, err)
}
// Execute the template
var buf bytes.Buffer
err = tmpl.Execute(&buf, context)
if err != nil {
return nil, fmt.Errorf("failed to execute template %s: %w", embeddedPath, err)
}
return buf.Bytes(), nil
}