diff --git a/assets/build/test.mk b/assets/build/test.mk index 0093c7b..e7691a2 100644 --- a/assets/build/test.mk +++ b/assets/build/test.mk @@ -5,7 +5,7 @@ ## Install go tools install-go-tools: @echo Installing go tools - $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 + $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0 $(GO) install gotest.tools/gotestsum@v1.7.0 ## Runs eslint and golangci-lint diff --git a/pluginctl.go b/pluginctl.go index 287c8e8..59d0de2 100644 --- a/pluginctl.go +++ b/pluginctl.go @@ -108,7 +108,7 @@ func SavePluginCtlConfig(manifest *model.Manifest, config *PluginCtlConfig) { manifest.Props["pluginctl"] = config } -// ValidateAndUpdateVersion checks the plugin version for compatibility. +// ValidateAndUpdateVersion checks the plugin version and updates it if necessary. func ValidateAndUpdateVersion(pluginPath string) error { // Load the manifest manifest, err := LoadPluginManifestFromPath(pluginPath) @@ -135,33 +135,15 @@ func ValidateAndUpdateVersion(pluginPath string) error { config.Version, currentVersion) } - return nil -} + // Update version if different + if config.Version != currentVersion { + config.Version = currentVersion + SavePluginCtlConfig(manifest, config) -// UpdatePluginCtlVersion updates the pluginctl version in the manifest. -func UpdatePluginCtlVersion(pluginPath string) error { - // Load the manifest - manifest, err := LoadPluginManifestFromPath(pluginPath) - if err != nil { - return fmt.Errorf("failed to load plugin manifest: %w", err) - } - - // Get current pluginctl version - currentVersion := GetVersion() - - // Parse existing pluginctl config - config, err := ParsePluginCtlConfig(manifest) - if err != nil { - return fmt.Errorf("failed to parse pluginctl config: %w", err) - } - - // Update version - config.Version = currentVersion - SavePluginCtlConfig(manifest, config) - - // Save the updated manifest - if err := WritePluginManifest(manifest, pluginPath); err != nil { - return fmt.Errorf("failed to update version in manifest: %w", err) + // Save the updated manifest + if err := WritePluginManifest(manifest, pluginPath); err != nil { + return fmt.Errorf("failed to update version in manifest: %w", err) + } } return nil diff --git a/updateassets.go b/updateassets.go index 8ee1fce..472b691 100644 --- a/updateassets.go +++ b/updateassets.go @@ -87,11 +87,6 @@ Examples: Logger.Info("Assets updated successfully!", "files_updated", updatedCount) - // Store the current pluginctl version in the manifest after successful update - if err := UpdatePluginCtlVersion(pluginPath); err != nil { - return fmt.Errorf("failed to save version to manifest: %w", err) - } - return nil }