- Add PluginCtlConfig struct with IgnoreAssets field for glob patterns - Add ParsePluginCtlConfig function to parse manifest props["pluginctl"] - Update updateassets command to respect ignore patterns with glob matching - Add comprehensive logging when files are skipped due to ignore patterns - Support patterns like *.test.js, build/, node_modules for flexible exclusion - Add extensive tests for config parsing and path matching functionality - Maintain backward compatibility with existing manifests - Fix Makefile check-changes target and add logger init to tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
215 lines
5.4 KiB
Go
215 lines
5.4 KiB
Go
package pluginctl
|
|
|
|
import (
|
|
"bytes"
|
|
"embed"
|
|
"fmt"
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
//go:embed assets/*
|
|
var assetsFS embed.FS
|
|
|
|
const (
|
|
assetsPrefix = "assets/"
|
|
assetsPrefixLen = 7
|
|
directoryPermissions = 0o750
|
|
filePermissions = 0o600
|
|
)
|
|
|
|
func RunUpdateAssetsCommand(args []string, pluginPath string) error {
|
|
if len(args) > 0 {
|
|
return fmt.Errorf("updateassets command does not accept arguments")
|
|
}
|
|
|
|
Logger.Info("Updating assets in plugin directory", "path", pluginPath)
|
|
|
|
manifest, err := LoadPluginManifestFromPath(pluginPath)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to load plugin manifest: %w", err)
|
|
}
|
|
|
|
pluginCtlConfig, err := ParsePluginCtlConfig(manifest)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to parse pluginctl config: %w", err)
|
|
}
|
|
|
|
hasWebapp := HasWebappCode(manifest)
|
|
updatedCount := 0
|
|
|
|
config := AssetProcessorConfig{
|
|
pluginPath: pluginPath,
|
|
hasWebapp: hasWebapp,
|
|
updatedCount: &updatedCount,
|
|
pluginCtlConfig: pluginCtlConfig,
|
|
}
|
|
|
|
err = fs.WalkDir(assetsFS, "assets", func(path string, d fs.DirEntry, err error) error {
|
|
return processAssetEntry(path, d, err, config)
|
|
})
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update assets: %w", err)
|
|
}
|
|
|
|
Logger.Info("Assets updated successfully!", "files_updated", updatedCount)
|
|
|
|
return nil
|
|
}
|
|
|
|
// isPathIgnored checks if a path matches any of the ignore patterns.
|
|
func isPathIgnored(relativePath string, ignorePatterns []string) (ignored bool, matchedPattern string) {
|
|
for _, pattern := range ignorePatterns {
|
|
// Direct file or path match
|
|
if matched, err := filepath.Match(pattern, relativePath); err == nil && matched {
|
|
return true, pattern
|
|
}
|
|
|
|
// Check if the path starts with the pattern (for directory patterns)
|
|
if strings.HasSuffix(pattern, "/") && strings.HasPrefix(relativePath, pattern) {
|
|
return true, pattern
|
|
}
|
|
|
|
// Check if any parent directory matches the pattern
|
|
if matchesParentDirectory(relativePath, pattern) {
|
|
return true, pattern
|
|
}
|
|
|
|
// Check if any directory component matches the pattern
|
|
if matchesDirectoryComponent(relativePath, pattern) {
|
|
return true, pattern
|
|
}
|
|
}
|
|
|
|
return false, ""
|
|
}
|
|
|
|
// matchesParentDirectory checks if any parent directory matches the pattern.
|
|
func matchesParentDirectory(relativePath, pattern string) bool {
|
|
dir := filepath.Dir(relativePath)
|
|
for dir != "." && dir != "/" {
|
|
if matched, err := filepath.Match(pattern, dir); err == nil && matched {
|
|
return true
|
|
}
|
|
// Also check direct string match for directory names
|
|
if filepath.Base(dir) == pattern {
|
|
return true
|
|
}
|
|
dir = filepath.Dir(dir)
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// matchesDirectoryComponent checks if any directory component matches the pattern.
|
|
func matchesDirectoryComponent(relativePath, pattern string) bool {
|
|
parts := strings.Split(relativePath, "/")
|
|
for _, part := range parts {
|
|
if matched, err := filepath.Match(pattern, part); err == nil && matched {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
type AssetProcessorConfig struct {
|
|
pluginPath string
|
|
hasWebapp bool
|
|
updatedCount *int
|
|
pluginCtlConfig *PluginCtlConfig
|
|
}
|
|
|
|
func processAssetEntry(path string, d fs.DirEntry, err error, config AssetProcessorConfig) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if path == "assets" {
|
|
return nil
|
|
}
|
|
|
|
relativePath := path[assetsPrefixLen:]
|
|
|
|
if !config.hasWebapp && strings.HasPrefix(relativePath, "webapp") {
|
|
return nil
|
|
}
|
|
|
|
// Check if path is ignored by pluginctl config
|
|
if ignored, pattern := isPathIgnored(relativePath, config.pluginCtlConfig.IgnoreAssets); ignored {
|
|
Logger.Info("Skipping asset due to ignore pattern", "path", relativePath, "pattern", pattern)
|
|
|
|
return nil
|
|
}
|
|
|
|
targetPath := filepath.Join(config.pluginPath, relativePath)
|
|
|
|
if d.IsDir() {
|
|
return createDirectory(targetPath)
|
|
}
|
|
|
|
return processAssetFile(path, targetPath, relativePath, config.updatedCount)
|
|
}
|
|
|
|
func processAssetFile(embeddedPath, targetPath, relativePath string, updatedCount *int) error {
|
|
shouldUpdate, err := shouldUpdateFile(embeddedPath, targetPath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if shouldUpdate {
|
|
err = updateFile(embeddedPath, targetPath, relativePath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
(*updatedCount)++
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func createDirectory(targetPath string) error {
|
|
if err := os.MkdirAll(targetPath, directoryPermissions); err != nil {
|
|
return fmt.Errorf("failed to create directory %s: %w", targetPath, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func shouldUpdateFile(embeddedPath, targetPath string) (bool, error) {
|
|
content, err := assetsFS.ReadFile(embeddedPath)
|
|
if err != nil {
|
|
return false, fmt.Errorf("failed to read embedded file %s: %w", embeddedPath, err)
|
|
}
|
|
|
|
existingContent, err := os.ReadFile(targetPath)
|
|
if err != nil {
|
|
// File doesn't exist or other error, should update
|
|
return true, nil //nolint:nilerr
|
|
}
|
|
|
|
return !bytes.Equal(existingContent, content), nil
|
|
}
|
|
|
|
func updateFile(embeddedPath, targetPath, relativePath string) error {
|
|
content, err := assetsFS.ReadFile(embeddedPath)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to read embedded file %s: %w", embeddedPath, err)
|
|
}
|
|
|
|
parentDir := filepath.Dir(targetPath)
|
|
if err := os.MkdirAll(parentDir, directoryPermissions); err != nil {
|
|
return fmt.Errorf("failed to create parent directory %s: %w", parentDir, err)
|
|
}
|
|
|
|
if err := os.WriteFile(targetPath, content, filePermissions); err != nil {
|
|
return fmt.Errorf("failed to write file %s: %w", targetPath, err)
|
|
}
|
|
|
|
Logger.Info("Updated file", "path", relativePath)
|
|
|
|
return nil
|
|
}
|