fmartingr/worldhopper
fmartingr/worldhopper
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases 14 Packages Activity Actions

feat: koreader sync #4

Open
fmartingr wants to merge 2 commits from feat/koreader-sync into master
pull from: feat/koreader-sync
merge into: fmartingr:master
Conversation 0 Commits 2 Files changed 25 +1540 -55
fmartingr commented 2026-02-15 13:01:32 +01:00
Owner
Copy link
No description provided. 
correctly
feat: koreader sync
All checks were successful
ci/woodpecker/pr/pr Pipeline was successful
Details
71651a6b21
fix: prevent double-save on exit, surface KOReader sync auth failures
All checks were successful
ci/woodpecker/pr/pr Pipeline was successful
Details
bb579719f9
 
- Add guard flag to prevent both onPopInvokedWithResult and dispose()
  from saving progress (double DB writes + double sync pushes)
- Capture ref-dependent values synchronously in _saveProgress before
  any await to prevent accessing disposed ref after super.dispose()
- Guard ref.invalidate() calls with mounted check for dispose safety
- Add KoreaderSyncAuthException so 401 errors in getProgress and
  updateProgress propagate instead of being silently swallowed
- Show a warning snackbar (once per session) when auth fails so the
  user knows sync credentials need updating

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
All checks were successful
ci/woodpecker/pr/pr Pipeline was successful
Details
This pull request has changes conflicting with the target branch.
  • lib/config/constants.dart
  • lib/database/database.dart
  • lib/database/tables/servers_table.dart
  • lib/models/opds_server.dart
  • lib/models/opds_server.freezed.dart
  • lib/models/opds_server.g.dart
  • lib/screens/reader/epub_reader_screen.dart
  • lib/screens/servers/add_server_screen.dart
  • lib/screens/servers/edit_server_screen.dart
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/koreader-sync:feat/koreader-sync
git switch feat/koreader-sync

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff feat/koreader-sync
git switch feat/koreader-sync
git rebase master
git switch master
git merge --ff-only feat/koreader-sync
git switch feat/koreader-sync
git rebase master
git switch master
git merge --no-ff feat/koreader-sync
git switch master
git merge --squash feat/koreader-sync
git switch master
git merge --ff-only feat/koreader-sync
git switch master
git merge feat/koreader-sync
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fmartingr/worldhopper!4
No description provided.